-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return address
from the from
and to
fields in a GraphQL
#6198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
60dfc9c
to
7234fad
Compare
When the world state is not retrievable, instead of returning java.lang.reflect.InvocationTargetException in the from field and null in the to field in GraphQL, return an empty account with the address only. Signed-off-by: Wetitpig <winsto003@hotmail.com>
Signed-off-by: Wetitpig <winsto003@hotmail.com>
Because it affects the behaviour of all GraphQL requests. Signed-off-by: Wetitpig <winsto003@hotmail.com>
Signed-off-by: Wetitpig <winsto003@hotmail.com>
Changes also added for the method |
Signed-off-by: Wetitpig <winsto003@hotmail.com>
shemnon
approved these changes
Nov 22, 2023
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Dec 4, 2023
…edger#6198) When the world state is not retrievable, instead of returning java.lang.reflect.InvocationTargetException in the from field and null in the to field in GraphQL, return an empty account with the address only. Signed-off-by: Wetitpig <winsto003@hotmail.com> Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Dec 4, 2023
…edger#6198) When the world state is not retrievable, instead of returning java.lang.reflect.InvocationTargetException in the from field and null in the to field in GraphQL, return an empty account with the address only. Signed-off-by: Wetitpig <winsto003@hotmail.com> Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Dec 4, 2023
…edger#6198) When the world state is not retrievable, instead of returning java.lang.reflect.InvocationTargetException in the from field and null in the to field in GraphQL, return an empty account with the address only. Signed-off-by: Wetitpig <winsto003@hotmail.com> Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
gfukushima
pushed a commit
to gfukushima/besu
that referenced
this pull request
Dec 15, 2023
…edger#6198) When the world state is not retrievable, instead of returning java.lang.reflect.InvocationTargetException in the from field and null in the to field in GraphQL, return an empty account with the address only. Signed-off-by: Wetitpig <winsto003@hotmail.com> Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Returns an empty
Account
with only theaddress
field in thefrom
andto
fields for a 'Transaction` instead of an error in a GraphQL request even if the world state is not retrievable.In addition an empty
Account
is also returned in thelogger
field.Sample input:
Sample output:
Fixed Issue(s)
fixes #6182